Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pre-commit #1664

Merged
merged 5 commits into from
Oct 4, 2022
Merged

Implement pre-commit #1664

merged 5 commits into from
Oct 4, 2022

Conversation

BobDotCom
Copy link
Member

Summary

Implements pre-commit hooks

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@BobDotCom BobDotCom added priority: high High Priority status: in progress Work in Progess labels Oct 3, 2022
@BobDotCom BobDotCom self-assigned this Oct 3, 2022
@BobDotCom BobDotCom marked this pull request as ready for review October 4, 2022 14:05
@BobDotCom BobDotCom enabled auto-merge (squash) October 4, 2022 14:05
Lulalaby
Lulalaby approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this breaks, not my fault

@BobDotCom BobDotCom requested a review from Dorukyum October 4, 2022 14:23
@BobDotCom BobDotCom merged commit 30e0de4 into master Oct 4, 2022
@BobDotCom BobDotCom deleted the pre-commit branch October 4, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@Middledot Middledot Awaiting requested review from Middledot

@ChickenDevs ChickenDevs Awaiting requested review from ChickenDevs

Assignees

@BobDotCom BobDotCom

Labels
priority: high High Priority status: in progress Work in Progess
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BobDotCom @Lulalaby @Dorukyum