Skip to content

[ext.bridge] Permission decorators and invoke function #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Oct 2, 2022
Merged

[ext.bridge] Permission decorators and invoke function #1642

merged 23 commits into from
Oct 2, 2022

Conversation

@Middledot
Copy link
Member

Summary

  • A guild_only and has_permissions decorator that can be used for both app and bridge commands for "frontend" and "backend" validation.
  • Allow BridgeCommand to be directly invoked (e.g.
@bridge.bridge_command()
async def a_command(self, ctx):
    await other_bridge_cmd.invoke(ctx, ...)

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Middledot Middledot added the ext.bridge Relating to ext.bridge label Sep 21, 2022
@Lulalaby Lulalaby added Merge with squash feature Implements a feature labels Sep 21, 2022
Dorukyum
Dorukyum previously requested changes Sep 26, 2022
View reviewed changes
@Lulalaby @Dorukyum
Update discord/ext/bridge/core.py
ba8c89a 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@BobDotCom
Copy link
Contributor

@Middledot please review requested changes

@Middledot
feat: add more extensive usage
963674d 
Allow the perms or guild only decorator to be used before the command decorator:

@\bridge.guild_only()
@\commands.command()
...
@Middledot Middledot requested a review from Dorukyum October 1, 2022 00:20
@BobDotCom
Copy link
Contributor

@Middledot please fix failing tests

@Middledot
Copy link
Member Author

@Middledot please fix failing tests

done

@Lulalaby Lulalaby enabled auto-merge (squash) October 1, 2022 03:41
@BobDotCom BobDotCom added this to the v2.2 milestone Oct 1, 2022
BobDotCom
BobDotCom previously approved these changes Oct 1, 2022
View reviewed changes
@Lulalaby Lulalaby merged commit 085b45a into Pycord-Development:master Oct 2, 2022
@Middledot Middledot deleted the ext-bridge-dev branch October 2, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BobDotCom BobDotCom BobDotCom approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

+1 more reviewer

@ChickenDevs ChickenDevs ChickenDevs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Middledot Middledot

Labels

ext.bridge Relating to ext.bridge feature Implements a feature

Projects

Pycord Releases
Status: Done

Milestone

v2.2

Development

Successfully merging this pull request may close these issues.

5 participants

@Middledot @BobDotCom @Dorukyum @ChickenDevs @Lulalaby