-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ext.bridge] Permission decorators and invoke function #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A decorator that adds a "backend" check and adds a "frontend" check for app commands
This reverts commit ebd3d50.
Dorukyum
previously requested changes
Sep 26, 2022
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Middledot please review requested changes |
Allow the perms or guild only decorator to be used before the command decorator: @\bridge.guild_only() @\commands.command() ...
@Middledot please fix failing tests |
done |
BobDotCom
previously approved these changes
Oct 1, 2022
BobDotCom
approved these changes
Oct 2, 2022
ChickenDevs
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
guild_only
andhas_permissions
decorator that can be used for both app and bridge commands for "frontend" and "backend" validation.Information
Checklist
type: ignore
comments were used, a comment is also left explaining why.