Skip to content

Conversation

@IKnewOne
Copy link
Contributor

@IKnewOne IKnewOne commented Aug 24, 2022

Summary

Adds support for "suppress" argument for messageable.send(), mirroring message.edit() suppression argument.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

IKnewOne and others added 10 commits September 3, 2022 19:54
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Emre Terzioglu <50607143+EmreTech@users.noreply.github.com>
Co-authored-by: Emre Terzioglu <50607143+EmreTech@users.noreply.github.com>
@Dorukyum Dorukyum requested a review from BobDotCom September 4, 2022 12:39
@ChickenDevs ChickenDevs merged commit b6ffeb1 into Pycord-Development:master Sep 6, 2022
honzajavorek added a commit to juniorguru/junior.guru that referenced this pull request Sep 13, 2022
@honzajavorek
Copy link
Contributor

Got

...
await thread.send(content=content, suppress=True)
TypeError: Messageable.send() got an unexpected keyword argument 'suppress'

when trying to use this with a thread, using version 2.1.3. It's late night here, so just noting it down as a comment. I'll try to verify and reproduce on a minimal example when I'm fresh and have more time. If I'm successful, I'll get back filing a separate issue.

@plun1331
Copy link
Member

Got

...
await thread.send(content=content, suppress=True)
TypeError: Messageable.send() got an unexpected keyword argument 'suppress'

when trying to use this with a thread, using version 2.1.3. It's late night here, so just noting it down as a comment. I'll try to verify and reproduce on a minimal example when I'm fresh and have more time. If I'm successful, I'll get back filing a separate issue.

This change isn't in 2.1.3

@honzajavorek
Copy link
Contributor

Oh! That would explain it then. This probably saved me hours of debugging, thank you 😀 I first got confused by docs (using the latest docs, but not the latest code from git means I may see new features not actually present in code), then by the order of the commits in the main branch, which got me thinking that this must be released since 2.1.2:

Screenshot 2022-09-14 at 11 27 12

Since .edit() supports it, workaround is easy (first send, then edit with suppress), so no stress.

honzajavorek added a commit to juniorguru/junior.guru that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants