Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added discord voice activites (Discord together) #1468

Closed
wants to merge 1 commit into from

Conversation

pogrammar
Copy link

In this pull request, I have added discord's voice activities. These are tried and tested from a separate repo and I thought to add this to pycord :)

Summary

This pull request adds discord's vc activites to py-cord. No, it does not fix any issues

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

In this pull request, I have added discord's voice activities. These are tried and tested from a separate repo and I thought to add this to pycord :)
@Lulalaby
Copy link
Member

Lulalaby commented Jul 5, 2022

Duplicate, already implemented ages ago

Additionally this pr isn't conform with our coding standards.

@Lulalaby Lulalaby closed this Jul 5, 2022
@pogrammar
Copy link
Author

@Lulalaby where is this implemented?

@Lulalaby
Copy link
Member

Lulalaby commented Jul 5, 2022

As example:
#320
#368

Was way before tho

@pogrammar pogrammar deleted the patch-1 branch July 5, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants