Skip to content

Conversation

@peco2282
Copy link
Contributor

@peco2282 peco2282 commented Jun 21, 2022

Summary

the first parameter of callable must be a parameter expression, so enclosed in square brackets.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby requested a review from a team June 22, 2022 00:01
@Dorukyum
Copy link
Member

This doesn't seem necessary according to the examples here: https://peps.python.org/pep-0612/#concatenating-keyword-parameters

@peco2282
Copy link
Contributor Author

This came up in my editor and I thought it was necessary.
If you don't need it, you can close it.

image

@Lulalaby
Copy link
Member

This doesn't seem necessary according to the examples here: https://peps.python.org/pep-0612/#concatenating-keyword-parameters

Yeah but maybe we can consider that.

Discussion for @Pycord-Development/maintainers and @Pycord-Development/contributors
Setting on hold for now.

@Lulalaby Lulalaby added priority: low Low Priority question Further information is requested labels Jun 22, 2022
@VincentRPS
Copy link
Contributor

I think its fine, if it makes type checkers happier.

@Lulalaby Lulalaby merged commit ecadcc4 into Pycord-Development:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low Low Priority question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants