Fix busy-loop in opus.py DecodeManager #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When decoding Opus frames (receiving audio), the run() function can end up busy-looping and consuming all the CPU if the decode queue is empty. A millisecond-long time.sleep prevents this. However, this may cause issues if more than 20 audio streams are being decoded, since Discord gives you an audio frame every 20 milliseconds - I have not looked into this.
Lulalaby
previously approved these changes
May 31, 2022
|
Maybe this could only sleep if the queue is empty? |
Good point! I tested it with that, and it still works and doesn't use up CPU. |
Lulalaby
approved these changes
May 31, 2022
plun1331
approved these changes
May 31, 2022
Lulalaby
added
bug
BobDotCom
approved these changes
Jun 10, 2022
Lulalaby
pushed a commit
that referenced
this pull request
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When decoding Opus frames (receiving audio), the run() function can end up busy-looping and consuming all the CPU if the decode queue is empty. A millisecond-long time.sleep, added by this PR, seems to prevent this.
However, this may cause issues if more than 20 audio streams are being decoded, since Discord gives you an audio frame every 20 milliseconds - I have not looked into this.As per @plun1331's suggestion, if we only sleep when the queue is empty, this should be avoided.Checklist
type: ignorecomments were used, a comment is also left explaining why