Skip to content

Add reason to delete_messages, fixes #1252 #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Middledot merged 1 commit into from
Apr 11, 2022
Merged

Add reason to delete_messages, fixes #1252 #1253

Middledot merged 1 commit into from
Apr 11, 2022

Conversation

@jab416171
Copy link
Contributor

@jab416171 jab416171 commented Apr 11, 2022

Summary

Adds reason in delete_messages to fix channel.purge

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added status: awaiting review Awaiting review from a maintainer priority: high High Priority labels Apr 11, 2022
@krittick krittick added this to the v2.0 milestone Apr 11, 2022
@Middledot Middledot linked an issue Apr 11, 2022 that may be closed by this pull request
ctx.channel.purge does not behave as expected in threads with version b7 #1252
Closed
3 tasks
@Middledot Middledot merged commit a3e1dd0 into Pycord-Development:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Middledot Middledot Middledot approved these changes

+1 more reviewer

@krittick krittick krittick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

priority: high High Priority status: awaiting review Awaiting review from a maintainer

Projects

None yet

Milestone

v2.0

Development

Successfully merging this pull request may close these issues.

ctx.channel.purge does not behave as expected in threads with version b7

3 participants

@jab416171 @krittick @Middledot