Fix option parsing

[BobDotCom]

Summary

Fixes option parsing... why was it like this in the first place

Checklist

• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why
• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed)
• This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

[krittick]

We should be clearer in using variable names, and this method still keeps the line length under 120.

[BobDotCom]

Rationale

The API sends resolved users (and other data types such as channels and roles) in the interaction data. This PR fixes option parsing to use that resolved data instead of using utils.get_or_fetch on the IDs passed.

Benchmarks

All times are relative times (i.e. they can be negative) but they are accurate when compared against each other.
Above red line: Before
Below red line: After
All benchmarks are run with the member intent disabled.

One user

In this benchmark we can see that the previous implementation slightly outperforms for the bots own user as it is always cached. The new implementation performs ~100-150ms faster for other users.

Five users

In this benchmark the bot user performs very similarly, but other users pull ahead by up to one second (1000ms).

X