Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement application command permissions v2 #1129

Merged
merged 14 commits into from
Mar 19, 2022
Merged

Implement application command permissions v2 #1129

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f0748e6
Remove v1 from application commands
Dorukyum Jan 15, 2022
4488210
Remove permissions v1 from documentation
Dorukyum Jan 15, 2022
291203c
Add v2 attributes to commands
Dorukyum Jan 15, 2022
6410974
Fix permissions for groups
Dorukyum Jan 15, 2022
0cc48ac
Use v2 in as_dict methods
Dorukyum Jan 15, 2022
abb059a
Add new permission decorator
Dorukyum Jan 15, 2022
7ca7fbf
Add missing return
Dorukyum Jan 16, 2022
feed5fe
Allow both kwargs and decorators for permissions
Dorukyum Jan 16, 2022
c07242c
Add guild_only decorator
Dorukyum Jan 16, 2022
5844e94
Allow decorating a command
Dorukyum Jan 16, 2022
c0200a0
Merge branch 'master' of https://github.com/Pycord-Development/pycord…
Dorukyum Feb 5, 2022
3853bcc
Merge branch 'master' into permissions-v2
Dorukyum Mar 7, 2022
362a282
Remove permissions v1 from docs
Dorukyum Mar 7, 2022
71c67d3
Merge branch 'master' into permissions-v2
BobDotCom Mar 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove v1 from application commands
  • Loading branch information
@Dorukyum
Dorukyum committed Jan 15, 2022
commit f0748e6f3e13043d60022db8b3e29535997e0fcd
4 changes: 0 additions & 4 deletions discord/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
from .context import ApplicationContext, AutocompleteContext
from .errors import ApplicationCommandError, CheckFailure, ApplicationCommandInvokeError
from .options import Option, OptionChoice
from .permissions import CommandPermission
from ..enums import SlashCommandOptionType
from ..errors import ValidationError, ClientException
from ..member import Member
Expand Down Expand Up @@ -550,7 +549,6 @@ def __init__(self, func: Callable, *args, **kwargs) -> None:

# Permissions
self.default_permission = kwargs.get("default_permission", True)
self.permissions: List[CommandPermission] = getattr(func, "__app_cmd_perms__", []) + kwargs.get("permissions", [])
if self.permissions and self.default_permission:
self.default_permission = False

Expand Down Expand Up @@ -870,7 +868,6 @@ def __init__(

# Permissions
self.default_permission = kwargs.get("default_permission", True)
self.permissions: List[CommandPermission] = kwargs.get("permissions", [])
if self.permissions and self.default_permission:
self.default_permission = False

Expand Down Expand Up @@ -1087,7 +1084,6 @@ def __init__(self, func: Callable, *args, **kwargs) -> None:
self.validate_parameters()

self.default_permission = kwargs.get("default_permission", True)
self.permissions: List[CommandPermission] = getattr(func, "__app_cmd_perms__", []) + kwargs.get("permissions", [])
if self.permissions and self.default_permission:
self.default_permission = False

Expand Down