Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for PartialMessageable TypeError in ext.pages #1116

Merged
merged 1 commit into from
Mar 5, 2022
Merged

Fix for PartialMessageable TypeError in ext.pages #1116

merged 1 commit into from
Mar 5, 2022

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Mar 5, 2022

Summary

This fixes the following error, which can occur if the paginator is sent after a deferred response:

TypeError: Expected TextChannel, DMChannel or Thread not <class 'discord.channel.PartialMessageable'>

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added priority: high High Priority bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. Merge normally ext.pages Relating to ext.pages labels Mar 5, 2022
@krittick krittick added this to the v2.0 milestone Mar 5, 2022
@krittick krittick self-assigned this Mar 5, 2022
@krittick krittick merged commit 5b2f35a into Pycord-Development:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@krittick krittick

Labels
bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. ext.pages Relating to ext.pages priority: high High Priority
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@krittick