Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for InputText.value not being properly cleared for non-required fields #1094

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

krittick
Copy link
Contributor

Summary

This fixes the logic for the value property on the ui.InputText class to allow clearing out a pre-filled value for a non-required input text field

Fixes #1092

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added bug Something isn't working priority: high High Priority bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. Merge normally labels Feb 28, 2022
@krittick krittick added this to the v2.0 milestone Feb 28, 2022
@krittick krittick self-assigned this Feb 28, 2022
@krittick krittick merged commit 81d7632 into Pycord-Development:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. priority: high High Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional Modal InputText fields with existing values do not accept empty strings
1 participant