Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last part of the screenshot is duplicated #23

Closed
agsoto opened this issue Jan 26, 2023 · 1 comment
Closed

Last part of the screenshot is duplicated #23

agsoto opened this issue Jan 26, 2023 · 1 comment

Comments

@agsoto
Copy link
Contributor

agsoto commented Jan 26, 2023

Bug description
There's a tiny miscalculation when pasting the last part of the image when the last remaining step of the scroll does not fit the entire viewport.

To Reproduce
Steps to reproduce the behavior:

  1. Create a instance of the Screenshot class
  2. Call the full_screenshot method setting the multi_images flag to true
  3. See the resulting image

Expected behavior
The image should not have repeated parts it should be visualized as the regular webpage in the browser.

Screenshot

Bad screenshot

Desktop

  • OS: Windows 11
  • Browser: Chromium
@sam4u3 sam4u3 closed this as completed in 3f7f560 Feb 3, 2023
sam4u3 added a commit that referenced this issue Feb 3, 2023
sam4u3 added a commit that referenced this issue Feb 3, 2023
sam4u3 added a commit that referenced this issue Feb 3, 2023
@chxlium
Copy link

chxlium commented Mar 27, 2023

Hello, it´s still happening to me when the page is long and I need to scroll down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants