Skip to content

Fix "data-preparation-and-post-processing.ipynb" - #6

Merged
bact merged 1 commit into
PyThaiNLP:masterfrom
c4n:master
Oct 1, 2019
Merged

Fix "data-preparation-and-post-processing.ipynb"#6
bact merged 1 commit into
PyThaiNLP:masterfrom
c4n:master

Conversation

@c4n

@c4n c4n commented Sep 12, 2019

Copy link
Copy Markdown

Description

In "data-preparation-and-post-processing.ipynb", the file path "./kaggle-competition/train.txt" does not lead to the correct directory. Also, there's a variable "b" that has not been declared and it causes error.

changes

  • Change ""./kaggle-competition/train.txt" to "../kaggle-competition/train.txt" to correct the file path
  • remove an undeclared variable "b"

@p16i
p16i requested review from bact and p16i September 19, 2019 07:19
@p16i

p16i commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

LGTM.

The notebook was made for a quick prototype. IMHO, we should migrate what inside the notebook to source code files. So, it's easier to cross-check and reproduce results.

@bact if you don't have any objection, i'm going to merge this PR.

@bact
bact merged commit 633a4df into PyThaiNLP:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants