Skip to content

Conversation

@bact
Copy link
Member

@bact bact commented Nov 4, 2024

  • Add notes on compact option to main readme
  • Add notes on tests in main readme and contributing
  • Remove references of no-longer-in-use AppVeyor (thank you for your service)
  • Up nlpo3 version to 1.3.0 (fixed karan bug)

- Add relevant nlpo3 test to testc
- Add notes on tests in main readme
- Up nlpo3 version to 1.3.0 (fixed karan bug)
@bact bact added the tests Unit test, code coverage, test case label Nov 4, 2024
Cannot build on Python 3.12 and 3.13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
33.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@bact bact changed the title Add nlpo3 to compact Add documentation about compact install option Nov 4, 2024
@bact bact added documentation improve documentation and test cases and removed tests Unit test, code coverage, test case labels Nov 4, 2024
@coveralls
Copy link

Coverage Status

coverage: 51.916% (+0.07%) from 51.85%
when pulling 5c48bb0 on bact:add-nlpo3-to-compact
into 93ecd91 on PyThaiNLP:dev.

@bact bact merged commit 1601e99 into PyThaiNLP:dev Nov 4, 2024
23 of 24 checks passed
@bact bact deleted the add-nlpo3-to-compact branch November 4, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation improve documentation and test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants