-
Notifications
You must be signed in to change notification settings - Fork 287
test: Add more cases too covered all possible Marttra #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @HRNPH! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-27 06:39:53 UTC |
bact
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wannaphong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Arthit Suriyawongkul <arthit@gmail.com>
|
|
Thank you merged. |



What does this changes
Add more testcase to covered all mattra to ensure the function was working properly
What was wrong
The testcase in pythainlp.khavee module didn't covered all Mattra
How this fixes it
กกา, แม่กก, แม่กง, แม่กด, แม่กน, แม่กบ, แม่กม, แม่เกย, แม่เกอวYour checklist for this pull request
🚨Please review the guidelines for contributing to this repository.