Skip to content

Conversation

@wannaphong
Copy link
Member

@wannaphong wannaphong commented Oct 29, 2021

What does this changes

Add nlpo3 to part of word_tokenize function.

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Oct 29, 2021

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-11-09 06:28:39 UTC

@wannaphong wannaphong requested a review from bact October 29, 2021 18:32
@wannaphong wannaphong changed the title Add nlpo3 [WIP] Add nlpo3 Oct 30, 2021
@coveralls
Copy link

coveralls commented Oct 30, 2021

Coverage Status

Coverage decreased (-0.1%) to 97.544% when pulling 8ef30c5 on add-nlpo3 into 6135ba5 on dev.

@bact bact added the enhancement enhance functionalities label Nov 8, 2021
@bact bact added this to the 3.0 milestone Nov 8, 2021
@bact
Copy link
Member

bact commented Nov 9, 2021

There's a bug in load_dict() output type, will fix in nlpo3-python 1.2.1
PyThaiNLP/nlpo3#50

Fixed.

@wannaphong
Copy link
Member Author

Thank you @bact

@wannaphong wannaphong merged commit 7a41b7b into dev Nov 9, 2021
@wannaphong wannaphong changed the title [WIP] Add nlpo3 Add nlpo3 Nov 9, 2021
@wannaphong wannaphong deleted the add-nlpo3 branch February 9, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement enhance functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants