-
Notifications
You must be signed in to change notification settings - Fork 287
Add Chinese-Thai Machine Translation #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Would be good to warn users that the models only work with torch==1.8.0 and transformers==4.6.0 |
|
Actually on second thought, @wannaphong should we refactor translator class to let users choose source and target languages? If we want to do more language pairs then it will eventually be too many classes with current setup. |
|
Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-13 15:06:34 UTC |
What does this changes
Add Chinese-Thai Machine Translation
from Ai builder
Google colab for testing: https://colab.research.google.com/drive/1XzMjQ170bsfkujFds0Fkgyi6vPxR8x-r?usp=sharing
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.