Skip to content

Conversation

@veer66
Copy link

@veer66 veer66 commented May 18, 2021

What does this changes

This change is removing the unreachable branch.

elif word[i] == _RO_RUA:
    word = word.replace(
        consonants[i], _CONSONANTS[consonants[i]][1]
    )
    i += 1

What was wrong

It made codebase hard to read.

How this fixes it

I manually remove this block by a text editor.

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test (I don't know how to run the linter for this project.)

This will fix #552

@coveralls
Copy link

coveralls commented May 18, 2021

Coverage Status

Coverage increased (+0.02%) to 95.767% when pulling 40671c3 on veer66:dev into c7a37b2 on PyThaiNLP:dev.

@bact bact added the refactoring a technical improvement which does not add any new features or change existing features. label May 19, 2021
@pep8speaks
Copy link

pep8speaks commented May 20, 2021

Hello @veer66! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-20 03:06:54 UTC

@bact bact added this to the 2.4 milestone May 20, 2021
@bact bact self-assigned this May 20, 2021
@bact bact merged commit 68c3e81 into PyThaiNLP:dev May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring a technical improvement which does not add any new features or change existing features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A possibly unreachable branch in royin.py

4 participants