-
Notifications
You must be signed in to change notification settings - Fork 287
Better CLI #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better CLI #251
Conversation
|
Hello @heytitle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-08-23 17:16:55 UTC |
pythainlp/cli/tokenization.py
Outdated
|
|
||
| @staticmethod | ||
| def syllable(args): | ||
| print("kenize syllable") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kenize syllable ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sry for that. It's just temporary code.
|
@heytitle It's ok. Can you add Part-of-Speech (POS) tags ? |
|
Sure! My local code was outdated, so that was why I didn't implement POS. I'm going to fix it. |
|
POS added. @wannaphongcom What do you think if we slightly change the interface of commands requiring text? In particular, it would be better if these commands receive a file instead of just a text, and write a result into another file. For example, IMHO, this is the way I would use CLIs. |
|
@heytitle I agree. It will greatly facilitate the use of the CLIs. |
|
Do you happen to know how many people use PyThaiNLP's CLI? I'm wondering whether we should create another PR for the receiving input as a file feature. What do you think? |
|
@heytitle I not know number of CLI users. I agree. We should create PR for the receiving input as a file feature. |
|
Now, Can i merge this pull request? |
|
@wannaphongcom yes |
related to #250
Example usages: