Skip to content

Conversation

@bact
Copy link
Member

@bact bact commented Apr 7, 2019

  • Fix misspelled filenames in setup.py (this was previously breaks NER)
  • More type hintings
  • Remove repetitive functions in spellcheckers
  • General code formatting
  • Move old docs to docs/archive
  • tcc.tcc() will now returns List[str], make it consistents with other tokenizers
  • add reverse flag to collate() to do reverse sort
  • isthai() (formerly is_thaiword()) and countthai() (formerly is_thai()) can now ignore customized characters (change names to make it more consistent with Python's str functions, e.g. isalpha, isdigit)
  • Update docs and tests accordingly

bact added 2 commits April 8, 2019 01:59
- More type hintings
- Update Get Started notebook
@bact bact requested a review from wannaphong April 7, 2019 19:07
@coveralls
Copy link

coveralls commented Apr 7, 2019

Coverage Status

Coverage increased (+0.2%) to 81.891% when pulling 9072664 on bact:dev into e19ec28 on PyThaiNLP:dev.

@bact bact changed the title Small fixes and code formatting NER fixes, code cleaning, and type hinting Apr 7, 2019
@bact bact merged commit 13aafe0 into PyThaiNLP:dev Apr 7, 2019
@wannaphong wannaphong mentioned this pull request Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants