Skip to content

Simplify calculate_f_year_f_dev() #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bact merged 8 commits into from
Dec 17, 2024
Merged

Simplify calculate_f_year_f_dev() #1031

bact merged 8 commits into from
Dec 17, 2024

Conversation

@bact
Copy link
Member

@bact bact commented Dec 15, 2024 •
edited
Loading

Use dict/array lookup instead of long if/else

@bact bact added the refactoring a technical improvement which does not add any new features or change existing features. label Dec 15, 2024
@bact bact requested a review from wannaphong December 15, 2024 15:58
@bact
Copy link
Member Author

bact commented Dec 15, 2024

@bkktimber @wannaphong Please help review. Esp if I mistyped any wrong numbers in the dict.

@bact bact mentioned this pull request Dec 15, 2024
Closed
@coveralls
Copy link

coveralls commented Dec 15, 2024 •
edited
Loading

Coverage Status

coverage: 52.903% (+0.1%) from 52.784%
when pulling d3c4943 on bact:simpify-calculate_f_year_f_dev
into 9a1274b on PyThaiNLP:dev.

@bact bact added this to the 5.1 milestone Dec 15, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

wannaphong
wannaphong approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@wannaphong wannaphong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯

@bact bact merged commit 8ab3bc4 into PyThaiNLP:dev Dec 17, 2024
25 checks passed
@bact bact deleted the simpify-calculate_f_year_f_dev branch December 17, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wannaphong wannaphong wannaphong approved these changes

Assignees

No one assigned

Labels

refactoring a technical improvement which does not add any new features or change existing features.

Projects

PyThaiNLP
Status: Done

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

Thai lunar date functions may need refactoring - currently too complex

3 participants

@bact @coveralls @wannaphong