Skip to content

Conversation

@wannaphong
Copy link
Member

Add clause_tokenize warnings from #1024

@wannaphong wannaphong added this to the 5.0 milestone Dec 12, 2024
@bact
Copy link
Member

bact commented Dec 12, 2024

Build failed. Something to do with fairseq

@sonarqubecloud
Copy link

@wannaphong
Copy link
Member Author

Build failed. Something to do with fairseq

It uses old unit test.

@bact
Copy link
Member

bact commented Dec 12, 2024

Any reason why don't we apply this change directly to 5.0.5?

@bact
Copy link
Member

bact commented Dec 12, 2024

Oh. Ok. Got it. This is going to be 5.0.5, right?

@bact bact merged commit 79e5d58 into 5.0 Dec 12, 2024
4 of 7 checks passed
@wannaphong
Copy link
Member Author

Oh. Ok. Got it. This is going to be 5.0.5, right?

You right.

@wannaphong wannaphong deleted the update-5.0 branch December 12, 2024 12:51
wannaphong added a commit that referenced this pull request Dec 12, 2024
-  Add clause_tokenize warnings #1026
@wannaphong wannaphong mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants