Docker image #3
Merged
Docker image #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have another idea. Maybe we can have 2 applications: one for API and the other one for the web interface. These two applications are different Docker images. Doing this way will allow us to optimise the API Docker for being used in production environment. |
|
@wannaphongcom could you please review the dev image and let me know what needs to be done before we can merge this PR? From what I can see, Soundex page is the only one left that needs modification. |
wannaphong
approved these changes
May 29, 2019
|
To test: Just in case something might go wrong, please try to run the command below before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make PyThaiNLP Web Demo runnable out of the box using Docker. Our plan is to provide a easy-to-use interface to test those algorithms implemented in PyThaiNLP (see also #2).
Detailed Plan
It seems
main.pyis outdated. Many PyThaiNLP's interfaces have been change. Thus, we need to update the script accordingly.Here are tasks that I plan to do
/about. This is mainly for debuting proposes.Improve UX for those pages as well as APIWe can do it later.Provide Postman bundle for API usageNo concrete use case.@wannaphongcom please let me know if you have any comments or suggestions.