Skip to content

PyThaiTTS v0.3.0#7

Merged
wannaphong merged 9 commits intomainfrom
dev
Jan 24, 2024
Merged

PyThaiTTS v0.3.0#7
wannaphong merged 9 commits intomainfrom
dev

Conversation

@wannaphong
Copy link
Member

  • Add Lunarlist TTS model (ONNX)
  • Change default model to Lunarlist TTS model

Full Changelog: v0.2.1...v0.3.0

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@pep8speaks
Copy link

pep8speaks commented Jan 24, 2024

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 9:80: E501 line too long (117 > 79 characters)
Line 9:98: E231 missing whitespace after ':'
Line 9:102: E252 missing whitespace around parameter equals
Line 9:103: E252 missing whitespace around parameter equals
Line 11:80: E501 line too long (84 > 79 characters)
Line 14:80: E501 line too long (87 > 79 characters)
Line 27:80: E501 line too long (136 > 79 characters)
Line 65:80: E501 line too long (81 > 79 characters)

Line 5:80: E501 line too long (116 > 79 characters)
Line 7:80: E501 line too long (99 > 79 characters)
Line 16:11: E225 missing whitespace around operator
Line 16:80: E501 line too long (341 > 79 characters)
Line 17:9: E225 missing whitespace around operator
Line 17:12: E231 missing whitespace after ':'
Line 17:20: E231 missing whitespace after ','
Line 19:1: E302 expected 2 blank lines, found 1
Line 21:7: E225 missing whitespace around operator
Line 22:15: E231 missing whitespace after ','
Line 24:1: E305 expected 2 blank lines after class or function definition, found 1
Line 27:16: E225 missing whitespace around operator
Line 28:22: E225 missing whitespace around operator
Line 30:1: E302 expected 2 blank lines, found 1
Line 57:80: E501 line too long (85 > 79 characters)
Line 169:1: E302 expected 2 blank lines, found 1
Line 171:80: E501 line too long (130 > 79 characters)
Line 171:93: E231 missing whitespace after ','
Line 172:80: E501 line too long (130 > 79 characters)
Line 172:93: E231 missing whitespace after ','
Line 173:80: E501 line too long (130 > 79 characters)
Line 173:93: E231 missing whitespace after ','
Line 174:80: E501 line too long (115 > 79 characters)
Line 174:90: E231 missing whitespace after ','
Line 175:5: E301 expected 1 blank line, found 0
Line 178:5: E301 expected 1 blank line, found 0
Line 178:33: E231 missing whitespace after ','
Line 178:80: E501 line too long (82 > 79 characters)
Line 183:21: E711 comparison to None should be 'if cond is not None:'
Line 187:52: E251 unexpected spaces around keyword / parameter equals
Line 187:54: E251 unexpected spaces around keyword / parameter equals
Line 187:69: E251 unexpected spaces around keyword / parameter equals
Line 187:71: E251 unexpected spaces around keyword / parameter equals
Line 187:80: E501 line too long (84 > 79 characters)
Line 189:27: W292 no newline at end of file

Comment last updated at 2024-01-24 06:37:32 UTC

@wannaphong wannaphong merged commit fd98dcb into main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants