Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Simplify edge handle generation in flow slice #150

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

preet-bhadra
Copy link
Collaborator

@preet-bhadra preet-bhadra commented Feb 10, 2025

Important

Simplifies edge handle generation in flowSlice.ts by defaulting to node IDs instead of titles.

  • Behavior:
    • Simplifies edge handle generation in initializeFlow reducer in flowSlice.ts.
    • Defaults sourceHandle and targetHandle to link.source_id and link.target_id respectively, instead of node titles.
  • Misc:
    • Removes unnecessary node title lookup for edge handle generation.

This description was created by Ellipsis for f8dd331. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to f8dd331 in 1 minute and 6 seconds

More details
  • Looked at 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/store/flowSlice.ts:160
  • Draft comment:
    Potential bug: The fallback for targetHandle uses link.source_id. Likely it should use link.target_id instead.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_JALuxQpHtGivAunO


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@preet-bhadra preet-bhadra merged commit 1c74116 into main Feb 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant