Skip to content

Correctly calculate memory of the job #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Correctly calculate memory of the job #313

merged 1 commit into from
Aug 24, 2023

Conversation

robgics
Copy link
Contributor

@robgics robgics commented Aug 24, 2023

  • Replace min_nodes (which doesn't exist) with num_nodes
  • Return mem_node instead of mem_cpu.

Based on the commented out code beneath it, this looks like a copy/paste error. It would go unnoticed so long as mem_cpu was a non-None value.

@tazend
Copy link
Member

tazend commented Aug 24, 2023

Looks good, thanks :)

@tazend tazend merged commit b435d68 into PySlurm:main Aug 24, 2023
@tazend tazend linked an issue Aug 24, 2023 that may be closed by this pull request
@robgics robgics deleted the job-mem-fix branch August 24, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy/Paste error in Job class memory property
2 participants