Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the export of scored reports in PyProphet, making the process more robust, modular, and efficient for both OSW (SQLite) and Parquet input formats. The main change is the introduction of specialized minimal readers for the scored report export, which handle missing columns/tables gracefully and unify the logic for both file types. Additional improvements include code cleanup, error handling, and improved filtering for IPF Q-values.
Export scored report refactor and improvements
pyprophet/io/export/osw.py,pyprophet/io/export/parquet.py) [1] [2]export_scored_reportto use the new reader dispatch mechanism, removing manual column selection and improving robustness for different input types. (pyprophet/export/export_report.py)Robustness and error handling
pyprophet/io/export/osw.py)pyprophet/io/export/osw.py,pyprophet/io/export/parquet.py) [1] [2]Filtering and reporting improvements
pyprophet/report.py) [1] [2]Code cleanup and formatting
pyprophet/io/export/osw.py) [1] [2] [3] [4] [5] [6]pyprophet/export/export_report.py)