change explode to using polars#153
Merged
singjc merged 2 commits intoPyProphet:masterfrom Jul 28, 2025
Merged
Conversation
singjc
approved these changes
Jul 28, 2025
Contributor
singjc
left a comment
singjc
left a comment
There was a problem hiding this comment.
Tests seem to pass 👍 , will merge as a temporary fix, but should eventually convert everything to polars at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With one of my datasets, pandas explode consumes a lot of memory and causes pyprophet to crash. Switching to polars should be functionally equivalent, and a lot faster and more memory efficient.
I am unsure if this breaks any tests