Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates GitHub Action #208

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updates GitHub Action #208

wants to merge 2 commits into from

Conversation

trevorb1
Copy link
Collaborator

@trevorb1 trevorb1 commented Mar 3, 2024

Changes proposed in this Pull Request

Updates the testing workflow file. I believe no configurations met the imposed filtering options on what os to run on. I have enabled running on main branch Linux.

Should address comment in issue #207. Not tagging it as a linked PR in case other items still need to be addressed with the action

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.

@ktehranchi
Copy link
Collaborator

I'm disabling the action until one of us spends time to properly set it up.

@trevorb1
Copy link
Collaborator Author

trevorb1 commented Mar 17, 2024

@ktehranchi Agreed! Maybe a silly question, but whats the goal of the action? (I do realize I was the author of the original issue ticket, but I can't quite remember haha)

  • To check if the snakemake workflow is still functional? In which case we can just use the dry run flag to test all the rules still connect?
  • To check if the snakemake workflow will run top to bottom? In which case we are having to create a seperate config file for every option in our config file? If this is the goal, I wonder if it is better to just test each script separately with simple network fixtures?
  • To check if the workflow will make choices we expect to confirm overall functionality? Like if we make OCGT super cheap, we expect all investments to be in OCGT. I think this is great, but I guess this will require some sort of additional logic on the results unless we just do visual inspections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants