feat: remove and disallow setting credentials in config #1989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coroa
reviewed
Jan 19, 2026
Member
coroa
left a comment
coroa
left a comment
There was a problem hiding this comment.
Looks mostly good. Will test tomorrow how the validation works!
Member
|
We also need to add |
Co-authored-by: Jonas Hörsch <coroa@posteo.de>
Member
Author
Is already |
Member
|
Cool, working as expected |
coroa
approved these changes
Jan 20, 2026
euronion
reviewed
Jan 20, 2026
euronion
reviewed
Jan 20, 2026
euronion
reviewed
Jan 20, 2026
euronion
reviewed
Jan 20, 2026
Contributor
|
Cool, thanks! |
Co-authored-by: Johannes HAMPP <42553970+euronion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
The snakemake config is written back to
n.meta, therefore any tokens which are set in the config can be leaked with the network. The PR removes the existing CORINE token config and adds a check to disallow passing Gurobi WLS tokens via the solver_options config. Instead environment variables should be used, which are now also read from.env.Ref PyPSA/PyPSA#1531, which allows passing gurobi secrets now also via
.envfile.