Skip to content

fix: treat SCIP condition gaplimit as optimal #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

fix: treat SCIP condition gaplimit as optimal #448

merged 1 commit into from
Apr 26, 2025

Conversation

siddharth-krishna
Copy link
Collaborator

Changes proposed in this Pull Request

As a SCIP developer pointed out in #447 (comment) the "gap limit reached" condition should be treated as an optimal termination condition.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@siddharth-krishna siddharth-krishna mentioned this pull request Apr 26, 2025
Merged
4 tasks
@FabianHofmann FabianHofmann merged commit 9838a63 into master Apr 26, 2025
21 checks passed
@FabianHofmann FabianHofmann deleted the scip-gap-limit-optimal branch April 26, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianHofmann FabianHofmann Awaiting requested review from FabianHofmann

@lkstrp lkstrp Awaiting requested review from lkstrp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharth-krishna @FabianHofmann