remove setuptools monkey patch #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
remove-monkey-patch
branch
from
fcd3a05 to
e2438d9
Compare
mgorny
reviewed
Apr 23, 2022
examples/rust_with_cffi/noxfile.py
Outdated
| @nox.session() | ||
| def test(session: nox.Session): | ||
| session.install(SETUPTOOLS_RUST, "pytest", "cffi") | ||
| session.install(SETUPTOOLS_RUST, "pytest", "cffi", "distutils-extra") |
There was a problem hiding this comment.
I don't think python-distutils-extra is on pypi (or at least I couldn't find it). I don't really know nox but if it just wraps pip, I suppose you could use the tarball: https://launchpad.net/python-distutils-extra/trunk/2.39/+download/python-distutils-extra-2.39.tar.gz
Member
Author
There was a problem hiding this comment.
Ehh, I can't manage to verify the crash with or without that tarball installed locally.
As you've verified the patch works, I'm happy 👍
davidhewitt
force-pushed
the
remove-monkey-patch
branch
from
e2438d9 to
3441f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the upstream PR in pypa/distutils#43 got released in setuptools 58, so we can bump dependency and drop our patching.
@mgorny is there a way in which you can test if this fixes #221? My hunch is that it will.