Skip to content

Add conversion table to guide #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

davidhewitt
Copy link
Member

@davidhewitt davidhewitt commented May 17, 2020

Closes #374

Tried to keep it clear and short, but cover all relevant detail. Happy to edit any terms, wording or other suggestions you have.

@davidhewitt davidhewitt force-pushed the doc-conversion-table branch 3 times, most recently from 4bcc44a to cd85cd2 Compare May 17, 2020 22:28
@kngwyu
Copy link
Member

kngwyu commented May 18, 2020

Thank you!
Generally, I think we should note both class name and mypy type.
E.g., object and Any, dict and Dict[K, V], ...

In addition, it would be great if we have a review from someone with expertise in Python(e.g., @birkenfeld).

@davidhewitt davidhewitt force-pushed the doc-conversion-table branch from cd85cd2 to b179855 Compare May 18, 2020 07:48
@davidhewitt
Copy link
Member Author

Thank you!
Generally, I think we should note both class name and mypy type.
E.g., object and Any, dict and Dict[K, V], ...

In the interest of not duplicating things I'm going to switch to use object, dict[K, V] etc. as that's the syntax that will be official from Python 3.9 (as per PEP 585)

Thanks for the review @birkenfeld - I've pushed some changes based on your feedback 👍

Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice 💯

@kngwyu
Copy link
Member

kngwyu commented May 18, 2020

@birkenfeld Thank you for your review 🙂

@davidhewitt davidhewitt force-pushed the doc-conversion-table branch from b179855 to 2813d2e Compare May 19, 2020 21:22
@davidhewitt
Copy link
Member Author

Thanks, have addressed the final points of feedback.

@kngwyu kngwyu merged commit 7fd35b2 into PyO3:master May 21, 2020
@davidhewitt davidhewitt deleted the doc-conversion-table branch December 24, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Add a table mapping Python types to Rust equivalents
3 participants