-
Notifications
You must be signed in to change notification settings - Fork 850
Add conversion table to guide #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4bcc44a
to
cd85cd2
Compare
Thank you! In addition, it would be great if we have a review from someone with expertise in Python(e.g., @birkenfeld). |
cd85cd2
to
b179855
Compare
In the interest of not duplicating things I'm going to switch to use Thanks for the review @birkenfeld - I've pushed some changes based on your feedback 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice 💯
@birkenfeld Thank you for your review 🙂 |
b179855
to
2813d2e
Compare
Thanks, have addressed the final points of feedback. |
Closes #374
Tried to keep it clear and short, but cover all relevant detail. Happy to edit any terms, wording or other suggestions you have.