Reduce build dependencies from regex - #848
Merged
Merged
Conversation
This avoids users compiling four crates for the "perf" and "unicode" features. regex is only used in build.rs to parse some #define lines so it doesn't need to compile support for thread-local caches etc or parsing by unicode code point.
kngwyu
approved these changes
Apr 7, 2020
Member
|
Good catch, thanks! |
kngwyu
added a commit
that referenced
this pull request
Apr 9, 2020
Reduce build dependencies from regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids users compiling four crates for the "perf" and
"unicode" features. regex is only used in build.rs to parse
some #define lines so it doesn't need to compile support for
thread-local caches etc or parsing by unicode code point.