provide an opt-out of raw-dylib#6185
Open
davidhewitt wants to merge 7 commits into
Open
Conversation
Member
Author
Member
|
Providing a opt-out sounds good to me. Note that I did also verify a revision of #6182 on github actions in https://github.com/messense/pyo3/actions/runs/28695802239 |
Contributor
I'm fine with any option (since I don't use these platforms) @ognevny what do you think about this? |
|
lgtm |
Member
Author
|
Thanks all, I think I will proceed to merge this and ship 0.29.1. (Probably will get it live tomorrow.) |
chirizxc
reviewed
Jul 5, 2026
| fn default_lib_name_windows(abi: PythonAbi, mingw: bool, debug: bool) -> Result<String> { | ||
| // mingw formats lib names like unix, and uses a "lib" prefix. We could let the linker | ||
| // handle "lib" prefix, but that means the `raw-dylib` name is incorrect (where the | ||
| // "lib" prefix is not automatically added).) |
Contributor
There was a problem hiding this comment.
- // "lib" prefix is not automatically added).)
+ // "lib" prefix is not automatically added)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix #6157
Where this differs from #6164 and #6182:
PYO3_USE_RAW_DYLIB=0opt-out.I verified this by hand on a windows box in a mingw environment; it seems to work correctly where
mainis broken.