Skip to content

Conversation

@davidhewitt
Copy link
Member

With const eval getting more powerful, we're able to drop the indoc and unindent dependencies for the py_run! macro.

@alex
Copy link
Contributor

alex commented Nov 7, 2025

Nice! We love dropping dependencies! Looks like this needs copy_from_slice (const-MSRV 1.87.0)?

@davidhewitt
Copy link
Member Author

Ah it's possible to implement that by hand, will fixup later 👍

@davidhewitt davidhewitt marked this pull request as ready for review November 8, 2025 18:01
@davidhewitt
Copy link
Member Author

Red CI:

I think this is good to review / merge?

@alex
Copy link
Contributor

alex commented Nov 9, 2025

unindent_bytes is a bit hard to read, but I think this all looks right. thanks!

Copy link
Contributor

@Tpt Tpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I allowed myself a review. Nice to see dependencies being removed

@davidhewitt
Copy link
Member Author

Thanks both for the reviews, I pushed a commit which attempts to improve readability!

@Tpt
Copy link
Contributor

Tpt commented Nov 18, 2025

Thank you! Much nicer!

@davidhewitt davidhewitt added this pull request to the merge queue Nov 18, 2025
Merged via the queue into PyO3:main with commit 2a0fb63 Nov 18, 2025
39 of 42 checks passed
@davidhewitt davidhewitt deleted the drop-indoc-unindent branch November 18, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants