-
Notifications
You must be signed in to change notification settings - Fork 901
drop unindent and indoc dependencies
#5608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f6d37b2 to
536f879
Compare
|
Nice! We love dropping dependencies! Looks like this needs |
|
Ah it's possible to implement that by hand, will fixup later 👍 |
|
Red CI:
I think this is good to review / merge? |
|
unindent_bytes is a bit hard to read, but I think this all looks right. thanks! |
Tpt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I allowed myself a review. Nice to see dependencies being removed
|
Thanks both for the reviews, I pushed a commit which attempts to improve readability! |
|
Thank you! Much nicer! |
With const eval getting more powerful, we're able to drop the
indocandunindentdependencies for thepy_run!macro.