refactor #[new] code generation
#5551
Merged
+334
−316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2025
Open
Member
Author
|
@Icxolu I cut the diff down here, it should be a reviewable size now except there's the failing |
Member
Author
|
Think this should be good to review and get the rest of the |
Icxolu
reviewed
Nov 13, 2025
Icxolu
approved these changes
Nov 14, 2025
Contributor
Icxolu
left a comment
Icxolu
left a comment
There was a problem hiding this comment.
Thanks for reworking, I think this looks great now 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by the question in #5421 (comment) and also my own struggles cleaning up #4951
This moves
__new__to be implemented using our "slot" method machinery. As a follow up sometime I will probably try and apply similar treatment to__call__.