Introspection: emit messages inline in the binaries instead of introducing a ptr+len indirection #5450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Tpt
force-pushed
the
elf-lld
branch
3 times, most recently
from
13c7df2 to
5ce2a1f
Compare
Tpt
force-pushed
the
elf-lld
branch
2 times, most recently
from
3d2f822 to
c808cc4
Compare
Tpt
commented
Sep 19, 2025
…ucing a ptr+len indirection Significantly simplifies the parsing I dropped the old code path, we can add it back if we want to maintain backward compatibility
davidhewitt
reviewed
Sep 19, 2025
| Chunk::deserialize(&mut Deserializer::from_slice(chunk)).with_context(|| { | ||
| // We take the first valid utf8 bytes, it's quite likely to be the actual chunk | ||
| // We use a 4096 upper bound for security | ||
| let chunk = str::from_utf8(&chunk[..4096]) |
Member
There was a problem hiding this comment.
I guess this also breaks if the annotation is greater than 4096 chars?
Should we potentially store each static as a #[repr(C)] struct of u32 size and then the bytes, so that we still have a length?
Contributor
Author
There was a problem hiding this comment.
It's a great idea. I'm going to implement it
Contributor
Author
There was a problem hiding this comment.
I guess this also breaks if the annotation is greater than 4096 chars?
Yes, but it's only an error message so I am not sure it's a big deal
davidhewitt
approved these changes
Sep 19, 2025
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
LGTM, thanks for identifying and fixing!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
@davidhewitt There was an issue with the expected stub files. Fix: aa65fff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly simplifies the parsing by avoiding to resolve pointers and fixes compatibility with LLD
I dropped the old code path, we can add it back if we want to maintain backward compatibility
Thanks to uniffi for the inspiration