introduce fast path to `LazyTypeObject::get_or_init` #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

davidhewitt merged 7 commits into PyO3:main from davidhewitt:type-object-fast-path

Aug 17, 2025

Member

davidhewitt commented Aug 15, 2025

Split from #5223, because this part of the refactor is worth pulling out and highlighting as a perf improvement (I think).

davidhewitt added 2 commits

August 15, 2025 20:21


          introduce fast path to LazyTypeObject::get_or_init

79dd182


          fix changelog name

0c2eb82

davidhewitt mentioned this pull request

add PyOnceLock type #5223

Merged

codspeed-hq bot commented Aug 15, 2025 •

edited

Loading

CodSpeed Performance Report

Merging #5324 will degrade performances by 12.85%

_{Comparing davidhewitt:type-object-fast-path (03334ff) with main (15045db)}

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 92 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
⚡	`ordered_dunder_methods`	3.1 µs	2.8 µs	+11.97%
⚡	`ordered_richcmp`	3.2 µs	2.6 µs	+20.94%
❌	`extract_float_cast_fail`	395.6 ns	453.9 ns	-12.85%

Icxolu reviewed

View reviewed changes

src/impl_/pyclass/lazy_type_object.rs Outdated Show resolved Hide resolved


          reduce duplication

08f2531

Icxolu approved these changes

View reviewed changes

src/impl_/pyclass/lazy_type_object.rs Outdated Show resolved Hide resolved


          fixup benchmark

123ed18

davidhewitt enabled auto-merge

August 15, 2025 22:00


          fixup clippy

davidhewitt added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks


          fixup doc

eca3aa9

davidhewitt enabled auto-merge

August 16, 2025 07:09

davidhewitt added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

davidhewitt added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

davidhewitt added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch

davidhewitt added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

Member Author

davidhewitt commented Aug 16, 2025

Seems flaky on downloads, will keep retrying 🤔

davidhewitt added this pull request to the merge queue

Contributor

Icxolu commented Aug 16, 2025

Looks like we're not the only ones hitting this currently: https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Channel.20manifest.20downloads.20timeout.20in.20GHA

github-merge-queue bot removed this pull request from the merge queue due to failed status checks


          Merge branch 'main' into type-object-fast-path

03334ff

davidhewitt enabled auto-merge

August 17, 2025 02:50

davidhewitt added this pull request to the merge queue

Merged via the queue into PyO3:main with commit b788b9b

36 of 39 checks passed

davidhewitt deleted the type-object-fast-path branch

August 17, 2025 03:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet