ci: change default Python version to 3.13 #5048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this has hit a genuine problem with 32-bit windows 3.13 bindings, will investigate later... |
davidhewitt
commented
Apr 4, 2025
Comment on lines
+187
to
+190
| #[cfg(all(Py_3_12, not(Py_3_13)))] | ||
| pub _co_instrumentation_version: u64, | ||
| #[cfg(Py_3_13)] | ||
| pub _co_instrumentation_version: libc::uintptr_t, |
There was a problem hiding this comment.
The definition changed in 3.13 but we missed it because the checks on x64 systems didn't notice it had changed (the physical size was the same for them).
|
I will merge this & add it to the 0.24.2 patch branch. |
davidhewitt
added a commit
that referenced
this pull request
Apr 7, 2025
* ci: change default Python version to 3.13 * fix FFI definition for `PyCodeObject`
davidhewitt
added a commit
that referenced
this pull request
Apr 21, 2025
* ci: change default Python version to 3.13 * fix FFI definition for `PyCodeObject`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably could have done this much earlier after 3.13.0 stable was released. Time to upgrade now :)