Drop stray executable bit from non-executable text files #5047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
approved these changes
Apr 4, 2025
|
thanks! |
davidhewitt
pushed a commit
that referenced
this pull request
Apr 4, 2025
davidhewitt
pushed a commit
that referenced
this pull request
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on updating pyo3 to version 0.24 in Fedora Linux, and noticed some issues with stray executable bits on files that are indeed not executable scripts.
Not sure why this keeps happening, but I think some editors / IDEs see files that start with
#!and think "this is a shebang! it's a script! let's mark it as executable when saving the file!", even if the file is Rust source code and just a toplevel attribute like#![allow(unused)], but that doesn't explain all the cases seen here ...I haven't added a changelog entry because this is an "internal" / cleanup thing that shouldn't affect users of pyo3, but if you prefer, I can add a changelog fragement.