Introspection: Fixes Mach-O parsing #5034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
(no changelog, this is a follow up to a previous not-relased-yet MR) |
Contributor
|
FYI: If you update
to then the issue will be automatically closed upon merging 😄 |
abrisco
reviewed
Apr 2, 2025
This was referenced Apr 2, 2025
birkenfeld
reviewed
Apr 2, 2025
davidhewitt
reviewed
Apr 4, 2025
| && nlist.n_sect != NO_SECT as usize | ||
| && is_introspection_symbol(name) | ||
| { | ||
| let section = §ions[nlist.n_sect - 1]; // Sections are counted from 1 |
Member
There was a problem hiding this comment.
Looks like this is a correction? Why did this not hit ci?
Contributor
Author
There was a problem hiding this comment.
Because there was a section right after with the exact same shift between positions in memory and positions in the file (a lot of Mach-O file do not have any shift and this is the case of the binary generated by maturin/cargo in the CI)
- properly pick the correct section - clean error when fixup chains are used
Tpt
force-pushed
the
tpt/introspection-bin-parsing
branch
from
4afa2be to
0e0f9d8
Compare
abrisco
reviewed
Apr 4, 2025
Co-authored-by: Andre Brisco <91817010+abrisco@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5023