Conversation
|
Hmm. There is a unused declaration error. Any suggestions how to fix that? |
|
These occur because with this there are new In the order from the error above, I think these should be 🤞:
|
|
Thanks, let's try it |
|
Yup, that seems to have done the trick. Is there anything else I should try? I will mark this as "draft" since it can wait for the release to be merged. |
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, I added a label so that the full CI will trigger if you push again to this branch. This should execute more PyPy3.11 jobs and give better feedback.
Aside, if pypy/pypy#3836 ever gets resolved it will vastly increase the amount of testing of PyPy we can do here, because we have an absolute heap of tests which use Py_Initialize to spawn interpreters and run basic checks. I think it's out of scope for me to find time to work on that for the foreseeable future sadly.
There was a problem hiding this comment.
Please rename this to 4760.packaging.md - we put the packaging section at the top so easier for users to notice this.
|
Unfortunately we are also unlikely to implement |
|
rebased off main to clear some conflicts |
|
PyPy 7.3.18 with Python3.11 has been released so I am marking this ready for review. |
alex
left a comment
There was a problem hiding this comment.
looks like many CI jobs are still failing, those will need to be resolved
|
I don't understand how this PR is causing hypothesis to time out when generating samples: |
I believe this was fixed in #4879, so probably a rebase is enough to fix it. |
|
rebased and force-pushed. |
|
Huh. No idea why CI is failing. |
|
I believe this is a known false positive in clippy |
|
The automatic merge failed. |
* allow pypy3.11 * run CI on pypy3.11 * change const declaration * change link name for PyExc_BaseExceptionGroup * PyObject_DelAttr* are inline functions on pypy3.11 * use nightly until official release * DOC: add a news fragment * conditionally compile 'use' statements * fix format * changes from review * pypy 3.11 released * fixes for PyPy * typo * exclude _PyInterpreterFrame on PyPy * more pypy fixes * more excluding _PyFrameEvalFunction on PyPy * fixes for PyPy struct differences * format * fix test --------- Co-authored-by: Icxolu <10486322+Icxolu@users.noreply.github.com>
* allow pypy3.11 * run CI on pypy3.11 * change const declaration * change link name for PyExc_BaseExceptionGroup * PyObject_DelAttr* are inline functions on pypy3.11 * use nightly until official release * DOC: add a news fragment * conditionally compile 'use' statements * fix format * changes from review * pypy 3.11 released * fixes for PyPy * typo * exclude _PyInterpreterFrame on PyPy * more pypy fixes * more excluding _PyFrameEvalFunction on PyPy * fixes for PyPy struct differences * format * fix test --------- Co-authored-by: Icxolu <10486322+Icxolu@users.noreply.github.com>
Support PyPy's python3.11. It is not officially released yet, but I wanted to be sure PyO3 works.
I am testing this branch elsewhere. Until there is an official release, I set the PR to use the nightly builds.
You may wish to hold off on merging this until the official release, that is fine with me.
Also I dropped PyPy3.9 since we no longer support it. Nothing has changed so it should JustWork(tm)
I had help from the discussions, thanks!