Test free-threaded build on all PRs #4631
Conversation
|
Oh well, the python-build-standalone python doesn't quite work out of the box. See indygreg/python-build-standalone#374. Going back to deadsnakes... |
|
It occurs to me that now might be a reasonable time to add a check to the nox test script for a free-threaded python and not run the abi3 tests in that case. Right now we're effectively running the tests twice since the free-threaded build just ignores the abi3 setting. I know that you're not really supposed to check for a particular build of Python with nox, but if I understand how we're using nox in CI, adding a check in the noxfile would get the job done. I'm not sure how to do it "correctly" in nox. |
.github/workflows/ci.yml
Outdated
| @@ -555,7 +555,7 @@ jobs: | |||
| - run: python3 -m nox -s test | |||
|
|
|||
| test-free-threaded: | |||
| if: ${{ contains(github.event.pull_request.labels.*.name, 'CI-build-full') || github.event_name != 'pull_request' }} | |||
| if: github.ref != 'refs/heads/main' | |||
There was a problem hiding this comment.
I think we do want to run this on main, because that's necessary to populate the GitHub Actions cache (don't ask me why they made it this way, it's their compute that we have to waste 😂).
| if: github.ref != 'refs/heads/main' |
There was a problem hiding this comment.
(It's for security reasons: You don't want PRs to pull caches from each other, otherwise one evil PR can poison the cache of a good PR, but it's fine to trust the cache of hte base branch.)
There was a problem hiding this comment.
Right, but I also believe that if the PR is merged it could be considered trustworthy and its cache contents could be imported into the base branch 😁
ngoldbaum
force-pushed
the
free-threaded-ci-always-run
branch
from
57068ae
to
c94c2cf
Compare
This makes the free-threaded CI fire on all PRs, which should hopefully allow us to spot flakey tests sooner. Also 3.13.0 is out, so this is now a build that's officially supported by upstream.
Unfortunately setup-python still doesn't support the free-threaded build. As an experiment, I'm using setup-uv to install a free-threaded build. I've been experimenting with setup-uv in the NumPy CI so I'm interested if the PyO3 tests find anything weird. I'll switch back to the deadsnakes build if the uv build proves problematic.