Use disallow instantiation flag for classes without the __new__ method #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahlinc
force-pushed
the
use-disallow-inst-flag
branch
from
045b2be
to
9bd1576
Compare
davidhewitt
reviewed
Oct 5, 2024
| assert exc_info.value.args == ( | ||
| "No constructor defined for ClassWithoutConstructor", | ||
| ) | ||
| assert exc_info.value.args == (exc_message,) |
There was a problem hiding this comment.
This test will be run on all of Python 3.7 through 3.13, so I think the parameterized test is a good start but this will need to account for the variety between versions too.
| pyclasses.ClassWithoutConstructor, | ||
| "cannot create 'builtins.ClassWithoutConstructor' instances", | ||
| ), | ||
| (ClassWithoutConstructor, "No constructor defined for ClassWithoutConstructor"), |
There was a problem hiding this comment.
This type is defined just above; we can change the message to match the expected Rust one to simplify the test. (Then there's just the differences across versions.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from Py 3.10 it's possible to prohibit instantiation by using
Py_TPFLAGS_DISALLOW_INSTANTIATIONflag instead of using a stub method.From the Python side it makes it clear if there is no
__new__attr on a class then it can't be instantiated.