adjust path for GIL Refs deprecation warnings#3968
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Mar 19, 2024
Merged
Conversation
LilyFirefly
approved these changes
Mar 18, 2024
Contributor
|
In my opinion this does look nicer, and separating the construct used purely for deprecation warnings makes sense, so that we can easily find them when it's finally time to remove the, again. |
Member
Author
|
Great! I'll rebase this once #3967 goes in and get this merged 👍 (Probably first thing in the morning now.) |
c393092 to
cd4ce09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the UI tests are emitting warnings like
That
pyo3::methodspath bothered me as I want to deprecate that module (probably a 0.22 thing at this point). I thought we might be able to get something more meaningful, so I shuffled code around a little. Now we get:Do folks think this is any nicer? Think we can make the path even better for readers?
cc @Icxolu as this probably will have merge conflicts with code you're typing 😬