Implement From<Bound<'py, T>> for PyErr#3881
Merged
davidhewitt merged 4 commits intoPyO3:mainfrom Feb 27, 2024
Merged
Conversation
davidhewitt
reviewed
Feb 21, 2024
LilyFirefly
force-pushed
the
pyerr-from-bound
branch
2 times, most recently
from
8ca687c to
2a0bfad
Compare
LilyFirefly
force-pushed
the
pyerr-from-bound
branch
from
2a0bfad to
ccde801
Compare
davidhewitt
reviewed
Feb 23, 2024
LilyFirefly
commented
Feb 23, 2024
davidhewitt
approved these changes
Feb 24, 2024
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
This looks good to me! I'd be glad to hear if anyone has other ideas on naming before we merge, if there's nothing better within a couple days let's go with ToPyErr.
LilyFirefly
force-pushed
the
pyerr-from-bound
branch
from
749265c to
ccde801
Compare
63 tasks
Member
|
It seems like there's no better name ideas and the alternative implementation and alternative designs run into orphan rules issues, so let's merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from #3820 (comment), I think this might be all that is needed.