Skip to content

deprecate Py::as_ref#3864

Merged
davidhewitt merged 4 commits intoPyO3:mainfrom
LilyFirefly:deprecate-py-as-ref
Feb 29, 2024
Merged

deprecate Py::as_ref#3864
davidhewitt merged 4 commits intoPyO3:mainfrom
LilyFirefly:deprecate-py-as-ref

Conversation

@LilyFirefly
Copy link
Contributor

@LilyFirefly LilyFirefly commented Feb 18, 2024

I think rewriting the docs to use the new API can happen in a different PR. The other outstanding bits I think will also be tidied up in other work.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 18, 2024

CodSpeed Performance Report

Merging #3864 will improve performances by 13.43%

Comparing LilyFoote:deprecate-py-as-ref (d212c64) with main (a15e4b1)

Summary

⚡ 2 improvements
✅ 65 untouched benchmarks

Benchmarks breakdown

Benchmark main LilyFoote:deprecate-py-as-ref Change
test_simple_args_kwargs_rs 35.3 µs 31.8 µs +11.22%
test_simple_kwargs_rs 35 µs 30.9 µs +13.43%

@LilyFirefly LilyFirefly marked this pull request as ready for review February 28, 2024 10:17
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Agreed re docs can be follow-up; for the remaining pieces I've left some suggestions...

@davidhewitt davidhewitt changed the title WIP: Deprecate Py::as_ref deprecate Py::as_ref Feb 28, 2024
LilyFirefly and others added 2 commits February 28, 2024 20:03
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks! 🚀

@davidhewitt davidhewitt added this pull request to the merge queue Feb 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2024
@davidhewitt
Copy link
Member

👍 yes I'm looking forward to using format argument capture when we bump MSRV 😅

@davidhewitt davidhewitt added this pull request to the merge queue Feb 29, 2024
Merged via the queue into PyO3:main with commit 56683ed Feb 29, 2024
@LilyFirefly LilyFirefly deleted the deprecate-py-as-ref branch February 29, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants