Merged
Conversation
CodSpeed Performance ReportMerging #3864 will improve performances by 13.43%Comparing Summary
Benchmarks breakdown
|
63 tasks
dede4d3 to
fcd5f8e
Compare
davidhewitt
reviewed
Feb 28, 2024
Member
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks!
Agreed re docs can be follow-up; for the remaining pieces I've left some suggestions...
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
davidhewitt
approved these changes
Feb 28, 2024
Member
davidhewitt
left a comment
There was a problem hiding this comment.
This looks great to me, thanks! 🚀
Member
|
👍 yes I'm looking forward to using format argument capture when we bump MSRV 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think rewriting the docs to use the new API can happen in a different PR. The other outstanding bits I think will also be tidied up in other work.