Replace as_ref(py) with Bound APIs#3863
Merged
davidhewitt merged 1 commit intoPyO3:mainfrom Feb 20, 2024
Merged
Conversation
CodSpeed Performance ReportMerging #3863 will degrade performances by 16.65%Comparing Summary
Benchmarks breakdown
|
davidhewitt
reviewed
Feb 18, 2024
davidhewitt
reviewed
Feb 19, 2024
Member
davidhewitt
left a comment
There was a problem hiding this comment.
Looks great, thanks. Added a new suggestion for the doc comment. (Maybe just drop that from this PR if you like my alternative proposal?) Otherwise good to merge!
6126024 to
0a4c9b5
Compare
davidhewitt
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the merge of #3705 we can tidy these up.