Skip to content

Replace as_ref(py) with Bound APIs#3863

Merged
davidhewitt merged 1 commit intoPyO3:mainfrom
LilyFirefly:more-as-ref-replacements
Feb 20, 2024
Merged

Replace as_ref(py) with Bound APIs#3863
davidhewitt merged 1 commit intoPyO3:mainfrom
LilyFirefly:more-as-ref-replacements

Conversation

@LilyFirefly
Copy link
Contributor

Following the merge of #3705 we can tidy these up.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 18, 2024

CodSpeed Performance Report

Merging #3863 will degrade performances by 16.65%

Comparing LilyFoote:more-as-ref-replacements (0a4c9b5) with main (0bb9cab)

Summary

⚡ 3 improvements
❌ 3 regressions
✅ 73 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main LilyFoote:more-as-ref-replacements Change
mapping_from_dict 327.8 ns 272.2 ns +20.41%
extract_float_downcast_success 453.3 ns 536.7 ns -15.53%
extract_float_extract_success 417.2 ns 500.6 ns -16.65%
list_via_downcast 157.2 ns 185 ns -15.02%
not_a_list_via_downcast 244.4 ns 216.7 ns +12.82%
sequence_from_list 355.6 ns 272.2 ns +30.61%

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Feb 18, 2024
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. Added a new suggestion for the doc comment. (Maybe just drop that from this PR if you like my alternative proposal?) Otherwise good to merge!

@LilyFirefly LilyFirefly force-pushed the more-as-ref-replacements branch from 6126024 to 0a4c9b5 Compare February 19, 2024 10:02
@davidhewitt davidhewitt added this pull request to the merge queue Feb 19, 2024
Merged via the queue into PyO3:main with commit 76dabd4 Feb 20, 2024
@LilyFirefly LilyFirefly deleted the more-as-ref-replacements branch February 20, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants