Skip to content

Convert LazyTypeObject to use the Bound API#3855

Merged
davidhewitt merged 1 commit intoPyO3:mainfrom
LilyFirefly:lazy-type-object-get-or-init-bound
Feb 18, 2024
Merged

Convert LazyTypeObject to use the Bound API#3855
davidhewitt merged 1 commit intoPyO3:mainfrom
LilyFirefly:lazy-type-object-get-or-init-bound

Conversation

@LilyFirefly
Copy link
Contributor

I found this during #3853.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch! Some quick thoughts and I wonder if this will benefit from #3705 being merged, which I'll go rebase now.

@LilyFirefly LilyFirefly force-pushed the lazy-type-object-get-or-init-bound branch from 13b5d96 to 32cf969 Compare February 17, 2024 22:41
@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Feb 17, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 17, 2024

CodSpeed Performance Report

Merging #3855 will improve performances by 10.2%

Comparing LilyFoote:lazy-type-object-get-or-init-bound (3ed9290) with main (f04ad56)

🎉 Hooray! pytest-codspeed just leveled up to 2.2.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 1 improvements
✅ 78 untouched benchmarks

Benchmarks breakdown

Benchmark main LilyFoote:lazy-type-object-get-or-init-bound Change
sequence_from_list 300 ns 272.2 ns +10.2%

@LilyFirefly LilyFirefly force-pushed the lazy-type-object-get-or-init-bound branch from 32cf969 to 3ed9290 Compare February 18, 2024 11:44
@LilyFirefly
Copy link
Contributor Author

@davidhewitt I think this is ready to merge.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed, thanks!

(Sorry, I opened this PR a few times but family then pulled me sideways, even though it was so short 🙈)

@davidhewitt davidhewitt added this pull request to the merge queue Feb 18, 2024
Merged via the queue into PyO3:main with commit b4dc854 Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants